Skip to content

feat(eslint): Update eslint to v9#318

Closed
Drevoed wants to merge 2 commits intostoatchat:mainfrom
Drevoed:feat/eslint
Closed

feat(eslint): Update eslint to v9#318
Drevoed wants to merge 2 commits intostoatchat:mainfrom
Drevoed:feat/eslint

Conversation

@Drevoed
Copy link
Copy Markdown
Contributor

@Drevoed Drevoed commented Oct 10, 2024

This PR involves bumping a major version of eslint, which in turn involves migrating to a flat configuration.
Also add a proper prettier autofix integrated into eslint to help ease the workflow and apply autofix to the client package.

Subtle changes:

  • replace deprecated @motionone/solid with solid-motionone (pluggable replacement)
  • replace @solid/devtools package with solid-devtools, an all-in-one
  • removed some rules and added some new ones

Notable information

This branch is based on #316. I'd rather rebase this branch on main after merging that one. But if you want me to separate them into two branches split from main - can do.

Preflight

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

The lockfile and the package json have become pretty dated, I have updated the versions to the latest.

Seems to be working fine except the fact that @solid-primitives/i18n got a major breaking change. But a good one, though.
Needs testing.
This PR involves bumping a major version of eslint, which in turn involves migrating to a flat configuration.
Also add a proper prettier autofix integrated into eslint to help ease the workflow.

Subtle changes:
- replace deprecated @motionone/solid with solid-motionone (pluggable replacement)
- replace @solid/devtools package with solid-devtools, an all-in-one
- removed some rules and added some new ones
@insertish
Copy link
Copy Markdown
Contributor

Contains changes from #316

@insertish
Copy link
Copy Markdown
Contributor

Closed in b8df4f6

@insertish insertish closed this Mar 31, 2025
@github-project-automation github-project-automation Bot moved this from 🚪 Blocked to Closed in Pull Request Overview Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants